-
Notifications
You must be signed in to change notification settings - Fork 509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support UnstructuredMesh for IndependentSource #2949
Conversation
Many thanks Patrick, I can give this go and feedback. |
Co-authored-by: Jonathan Shimwell <[email protected]>
Just been making use of this branch, it successfully produced a mesh source on an unstructured mesh. Tagging @rlbarker for your interest I used this python script, attached .h5m file and produced a nice html plot of the result. |
This all looks good @pshriwise and it works nicely over here. The only part I don't quite get is why are the |
Thanks for explaining that tuple use. All looks good here to me. Shall we leave it open for a few days in case other comments come in. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can merge this Friday evening (UK time) unless there are an objections or further comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pshriwise I made a few little renaming changes -- hope you don't mind! One request that I couldn't handle directly:
Co-authored-by: Jonathan Shimwell <[email protected]> Co-authored-by: Paul Romano <[email protected]>
Description
This PR contains a fix in
source.py
that allows for application of theUnstructuredMesh
class in aMeshSource
object. It also has some quality-of-life updates for theUnstrucutredMesh
class:indices
property to theUnstructuredMesh
class and as an abstract property to theMeshBase
class.MeshSource
Partially Fixes #2929 -- I'll be creating a follow-on PR to support addition of the statepoint properties from the Python API next.
Checklist
[ ] I have run clang-format (version 15) on any C++ source files (if applicable)