Ensure that two surfaces with different boundary type are not considered redundant #2942
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Right now, if you are exporting a model and ask it to remove redundant surfaces (
Geometry.merge_surfaces = True
), it compares the surface type and coefficients to determine whether two surfaces are considered equivalent. However, theboundary_type
is not currently accounted for, which can cause problems if you have one surface with a boundary condition applied and another surface with no BC that is used on a lower universe level. This PR simply makes a change to account for theboundary_type
when determining whether two surfaces are equivalent.Checklist
I have run clang-format (version 15) on any C++ source files (if applicable)I have made corresponding changes to the documentation (if applicable)