Print warning if no natural isotopes when using add_element and wrote unit test #2938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulromano
requested changes
Apr 8, 2024
There was a problem hiding this comment.
Thanks @cxtherineyu for this addition! One request regarding the warning:
3 tasks
paulromano
approved these changes
Apr 24, 2024
church89
pushed a commit
to openmsr/openmc
that referenced
this pull request
Jul 18, 2024
… unit test (openmc-dev#2938) Co-authored-by: Catherine Yu <[email protected]> Co-authored-by: Paul Romano <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When adding nuclides to a material with add_element, OpenMC will silently do nothing if there are no natural nuclides of that element (e.g., plutonium, technetium). It would be nice if the user encountered a warning about this, because if the user was trying to do this in the first place, they did not realize/recognize that there aren't actually any natural isotopes for that element.
I created a custom Warning class called 'NoNaturalIsotopesWarning' so warnings can be correctly filtered by the end user instead of just calling Warnings.warn("").
I added a check here in the expand method to check the length of nuclides found and print a warning if
len(natural_nuclides) == 0.Fixes # 2926
Checklist