Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meshborn filter #2925

Merged
merged 3 commits into from
Apr 4, 2024
Merged

Conversation

JoffreyDorville
Copy link
Contributor

@JoffreyDorville JoffreyDorville commented Mar 27, 2024

Description

This PR adds a new tally filter to score events based on the mesh cell a particle originated from. This filter is particularly useful to compute mesh-based fission matrix which will be implemented in a following PR.

This feature is based on a previous development @alhajri of the CLUTCH-FM method using OpenMC for sensitivity analysis [1].

Reference

[1] Xingjie Peng, Jingang Liang, Abdulla Alhajri, Benoit Forget, Kord Smith, Development of continuous-energy sensitivity analysis capability in OpenMC, Annals of Nuclear Energy, Volume 110, 2017, Pages 362-383, ISSN 0306-4549, https://doi.org/10.1016/j.anucene.2017.06.061. (https://www.sciencedirect.com/science/article/pii/S0306454917301895)

Checklist

  • I have performed a self-review of my own code
  • I have run clang-format (version 15) on any C++ source files (if applicable)
  • I have followed the style guidelines for Python source files (if applicable)
  • I have made corresponding changes to the documentation (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)

@giovanni-mariano
Copy link

Hello @JoffreyDorville, very nice feature! Possible applications also in fusion: in the performance assessment of the detectors for different plasma scenarios or in SDDR studies for the identification and classification of the gamma sources that contribute to a specific tally.
It would be cool to get not only the position but also the initial energy of the particle (if possible).

Giovanni

Copy link
Contributor

@paulromano paulromano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a few cosmetic updates but otherwise looks good. Thanks for the work on this @JoffreyDorville!

@paulromano paulromano enabled auto-merge (squash) April 4, 2024 20:15
@paulromano paulromano merged commit cc848ef into openmc-dev:develop Apr 4, 2024
17 checks passed
church89 pushed a commit to openmsr/openmc that referenced this pull request Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants