Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restricted file source #2916

Merged
merged 63 commits into from
May 15, 2024
Merged

Restricted file source #2916

merged 63 commits into from
May 15, 2024

Commits on Mar 11, 2024

  1. add code to reject on domains also for file sources

    @ebknudsen
    ebknudsen committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    3df948b View commit details
    Browse the repository at this point in the history

  2. also add the domain restriction to python layer

    @ebknudsen
    ebknudsen committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    9e850f6 View commit details
    Browse the repository at this point in the history

  3. move rejection to the sampling step 

    it appears that before that geometry is not initialized
    @ebknudsen
    ebknudsen committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    35e160c View commit details
    Browse the repository at this point in the history

  4. improve commenting and formatting

    @ebknudsen
    ebknudsen committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    0fbc48d View commit details
    Browse the repository at this point in the history

  5. fix flipped logic

    @ebknudsen
    ebknudsen committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    471a4aa View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2024

  1. add option to kill non-conforming particles 

    add an option to, if a particle is rejected, kill
that one and move to next particle instead of resampling.
This is less efficient, but avoids renormalization
    @ebknudsen
    ebknudsen committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    972a281 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2024

  1. add option to reject by hypercube of particles

    @ebknudsen
    ebknudsen committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    b1537a7 View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2024

  1. allow hypercube description in python layer

    @ebknudsen
    ebknudsen committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    e12732b View commit details
    Browse the repository at this point in the history

  2. fix typos

    @ebknudsen
    ebknudsen committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    03e122c View commit details
    Browse the repository at this point in the history

  3. fix typos

    @ebknudsen
    ebknudsen committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    1baf072 View commit details
    Browse the repository at this point in the history

  4. yet another misprint

    @ebknudsen
    ebknudsen committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    916315e View commit details
    Browse the repository at this point in the history

  5. Merge branch 'restricted_file_source' of github.com:ebknudsen/openmc … 

    …into restricted_file_source
    @ebknudsen
    ebknudsen committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    248353d View commit details
    Browse the repository at this point in the history

  6. hypercube and rejection_strategy added to python 

    also apply a bit of formatting
    @ebknudsen
    ebknudsen committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    672f4e6 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'openmc-dev:develop' into restricted_file_source

    @ebknudsen
    ebknudsen authored Mar 14, 2024
    Configuration menu
    Copy the full SHA
    11da3c5 View commit details
    Browse the repository at this point in the history

  8. adjust whitespace acc. to clang-format

    @ebknudsen
    ebknudsen committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    ed46945 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'restricted_file_source' of github.com:ebknudsen/openmc … 

    …into restricted_file_source
    @ebknudsen
    ebknudsen committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    183779f View commit details
    Browse the repository at this point in the history

  10. remove unimplemented FILTER option

    @ebknudsen
    ebknudsen committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    5a892f8 View commit details
    Browse the repository at this point in the history

  11. fix var name

    @ebknudsen
    ebknudsen committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    eed4aaf View commit details
    Browse the repository at this point in the history

  12. initialize attributes to None

    @ebknudsen
    ebknudsen committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    bb8e892 View commit details
    Browse the repository at this point in the history

  13. initialize the rej. stragtegy and add doc string

    @ebknudsen
    ebknudsen committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    23a29b4 View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2024

  1. correct wrong condition

    @church89
    church89 committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    20b27f8 View commit details
    Browse the repository at this point in the history

  2. Merge pull request openmc-dev#29 from openmsr/correct_iterator 

    correct wrong condition
    @church89
    church89 authored Mar 19, 2024
    Configuration menu
    Copy the full SHA
    c188fab View commit details
    Browse the repository at this point in the history

  3. move from a single vector to discrete bounds 

    instead of a full coordinate vector instead use lower_left
upper_right for spatial coordinates, and energy_bounds and time_bounds
for energy and time. This should be more workable
    @ebknudsen
    ebknudsen committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    d93ac83 View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2024

  1. source restriction is now an intermediate class 

    The source may now be restricted if it inherits from
RestrictedSource instead of directly from Source
    @ebknudsen
    ebknudsen committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    86ae064 View commit details
    Browse the repository at this point in the history

  2. apply clang-format

    @ebknudsen
    ebknudsen committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    78a8716 View commit details
    Browse the repository at this point in the history

  3. use limits instead of cfloats

    @ebknudsen
    ebknudsen committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    c0a2f31 View commit details
    Browse the repository at this point in the history

  4. check bounds for pair assignement

    @ebknudsen
    ebknudsen committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    6dad9f8 View commit details
    Browse the repository at this point in the history

  5. default to kill - not resample

    @ebknudsen
    ebknudsen committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    6831f7d View commit details
    Browse the repository at this point in the history

  6. better style (dont use and...)

    @ebknudsen
    ebknudsen committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    b45f343 View commit details
    Browse the repository at this point in the history

  7. prefer ! to not

    @ebknudsen
    ebknudsen committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    a0cd9ec View commit details
    Browse the repository at this point in the history

  8. better style

    @ebknudsen
    ebknudsen committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    4671d90 View commit details
    Browse the repository at this point in the history

  9. apply clang-format

    @ebknudsen
    ebknudsen committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    bd8978b View commit details
    Browse the repository at this point in the history

  10. fix typo

    @ebknudsen
    ebknudsen committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    e342243 View commit details
    Browse the repository at this point in the history

  11. remove restr. source class

    @ebknudsen
    ebknudsen committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    6ede6ef View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2024

  1. remove useless code

    @ebknudsen
    ebknudsen committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    3453353 View commit details
    Browse the repository at this point in the history

  2. don't search for xs for already dead particles

    @ebknudsen
    ebknudsen committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    aa86285 View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2024

  1. fix particle search logic to allow fissionable to work

    @ebknudsen
    ebknudsen committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    ca03b4d View commit details
    Browse the repository at this point in the history

  2. revert to having resample as the default 

    resample has been the normal behavior asn should remain so
    @ebknudsen
    ebknudsen committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    306137d View commit details
    Browse the repository at this point in the history

  3. fix domain search logic which accepted particles regardless

    @ebknudsen
    ebknudsen committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    45b2a08 View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2024

  1. Merge branch 'develop' into restricted_file_source

    @ebknudsen
    ebknudsen authored Apr 22, 2024
    Configuration menu
    Copy the full SHA
    0152c2b View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2024

  1. Check for restriction nodes in MeshSource

    @paulromano
    paulromano committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    5b36f80 View commit details
    Browse the repository at this point in the history

  2. Get rid of lower_left, upper_right. Use GeomState instead of Particle

    @paulromano
    paulromano committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    96e89f8 View commit details
    Browse the repository at this point in the history

Commits on May 1, 2024

  1. Consolidate common logic in source.py

    @paulromano
    paulromano committed May 1, 2024
    Configuration menu
    Copy the full SHA
    44b4c20 View commit details
    Browse the repository at this point in the history

  2. Generalize source rejection on C++ side

    @paulromano
    paulromano committed May 1, 2024
    Configuration menu
    Copy the full SHA
    cf60499 View commit details
    Browse the repository at this point in the history

  3. Preserve per-element probabilities for MeshSource

    @paulromano
    paulromano committed May 1, 2024
    Configuration menu
    Copy the full SHA
    0395150 View commit details
    Browse the repository at this point in the history

  4. Add missing dummy method on MeshSource

    @paulromano
    paulromano committed May 1, 2024
    Configuration menu
    Copy the full SHA
    71538d2 View commit details
    Browse the repository at this point in the history

Commits on May 7, 2024

  1. Merge branch 'develop' into pr/ebknudsen/2916

    @paulromano
    paulromano committed May 7, 2024
    Configuration menu
    Copy the full SHA
    989d4ae View commit details
    Browse the repository at this point in the history

  2. Remove superfluous check in transport_history_based_single_particle

    @paulromano
    paulromano committed May 7, 2024
    Configuration menu
    Copy the full SHA
    4ca3996 View commit details
    Browse the repository at this point in the history

  3. Use single constraints argument in source classes

    @paulromano
    paulromano committed May 7, 2024
    Configuration menu
    Copy the full SHA
    9755ac9 View commit details
    Browse the repository at this point in the history

  4. Check for constraints/strength in Source constructor

    @paulromano
    paulromano committed May 7, 2024
    Configuration menu
    Copy the full SHA
    99eb170 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2024

  1. Extend tests for source constraints

    @paulromano
    paulromano committed May 9, 2024
    Configuration menu
    Copy the full SHA
    31ad069 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2024

  1. Respond to many @gridley comments

    @paulromano
    paulromano committed May 10, 2024
    Configuration menu
    Copy the full SHA
    0e2f747 View commit details
    Browse the repository at this point in the history

  2. Add fissionable source constraint

    @paulromano
    paulromano committed May 10, 2024
    Configuration menu
    Copy the full SHA
    cd04ecb View commit details
    Browse the repository at this point in the history

  3. Rename to sample / sample_with_constraints

    @paulromano
    paulromano committed May 10, 2024
    Configuration menu
    Copy the full SHA
    91cfdcc View commit details
    Browse the repository at this point in the history

Commits on May 13, 2024

  1. Make sample_with_constraints non-virtual

    @paulromano
    paulromano committed May 13, 2024
    Configuration menu
    Copy the full SHA
    a60ff90 View commit details
    Browse the repository at this point in the history

  2. Add user's guide section on source constraints

    @paulromano
    paulromano committed May 13, 2024
    Configuration menu
    Copy the full SHA
    e3f56e7 View commit details
    Browse the repository at this point in the history

  3. Put source constraints into a <constraints> XML element

    @paulromano
    paulromano committed May 13, 2024
    Configuration menu
    Copy the full SHA
    e468dd4 View commit details
    Browse the repository at this point in the history

  4. Add comment describing Source base/derived relationship

    @paulromano
    paulromano committed May 13, 2024
    Configuration menu
    Copy the full SHA
    42d5cad View commit details
    Browse the repository at this point in the history

Commits on May 14, 2024

  1. Update reference inputs to reflect contraints format

    @paulromano
    paulromano committed May 14, 2024
    Configuration menu
    Copy the full SHA
    c9d130d View commit details
    Browse the repository at this point in the history

  2. Fix one more reference input file

    @paulromano
    paulromano committed May 14, 2024
    Configuration menu
    Copy the full SHA
    bad3a01 View commit details
    Browse the repository at this point in the history

  3. Implement rejection fraction check in sample_with_constraints

    @paulromano
    paulromano committed May 14, 2024
    Configuration menu
    Copy the full SHA
    42898cc View commit details
    Browse the repository at this point in the history

  4. Fix rejection threshold check in sample_with_constraints

    @paulromano
    paulromano committed May 14, 2024
    Configuration menu
    Copy the full SHA
    ca3ba80 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2024

  1. Skip rejection limit test for MPI config

    @paulromano
    paulromano committed May 15, 2024
    Configuration menu
    Copy the full SHA
    da08d77 View commit details
    Browse the repository at this point in the history