-
Notifications
You must be signed in to change notification settings - Fork 509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed CI to use latest actions to get away from the Node 16 deprecation. #2912
Conversation
Co-authored-by: Paul Romano <[email protected]>
Co-authored-by: Paul Romano <[email protected]>
Another question: do we just pin to |
I'm personally fine sticking with our current mode of operation. The major updates to these actions don't seem to happen that frequently so updating once in a while as we have been doing is fine IMO. |
@MicahGale if you want to remove the draft status on this PR, I think it's ready to go. |
@paulromano There's still a dozen docker workflows to update. I was going to make a patch and try applying it to all docker files and see how that goes. |
@paulromano on next release could you remember to check for any warning logs in the deploy CI? |
I noticed we make use of perhaps this could also be updated to version 2.2.3 or simply 2 |
So the issue here is that coveralls has a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good, including that coveralls one going to v2. Thanks!
…tion. (openmc-dev#2912) Co-authored-by: Paul Romano <[email protected]>
Description
This pegs GHA to the latest versions for all actions. See #2905 for more context. To review this the most important thing is to check the CI runs for warnings in the summary.
Fixes #2905
Checklist
I have made corresponding changes to the documentation (if applicable)I have added tests that prove my fix is effective or that my feature works (if applicable)