Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed CI to use latest actions to get away from the Node 16 deprecation. #2912

Merged
merged 8 commits into from
Mar 13, 2024

Conversation

MicahGale
Copy link
Contributor

@MicahGale MicahGale commented Mar 12, 2024

Description

This pegs GHA to the latest versions for all actions. See #2905 for more context. To review this the most important thing is to check the CI runs for warnings in the summary.

Fixes #2905

Checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)

.github/workflows/dockerhub-publish-dev.yml Outdated Show resolved Hide resolved
.github/workflows/dockerhub-publish-dev.yml Outdated Show resolved Hide resolved
MicahGale and others added 2 commits March 12, 2024 10:18
@MicahGale
Copy link
Contributor Author

Another question: do we just pin to @master? This would introduce some risk of an action in the future breaking our workflow, but on the upside, never having to go through this process again really.

@paulromano
Copy link
Contributor

Another question: do we just pin to @master?

I'm personally fine sticking with our current mode of operation. The major updates to these actions don't seem to happen that frequently so updating once in a while as we have been doing is fine IMO.

@paulromano
Copy link
Contributor

@MicahGale if you want to remove the draft status on this PR, I think it's ready to go.

@MicahGale
Copy link
Contributor Author

@paulromano There's still a dozen docker workflows to update. I was going to make a patch and try applying it to all docker files and see how that goes.

@MicahGale MicahGale marked this pull request as ready for review March 13, 2024 01:39
@MicahGale MicahGale requested a review from paulromano March 13, 2024 01:39
@MicahGale
Copy link
Contributor Author

@paulromano on next release could you remember to check for any warning logs in the deploy CI?

@shimwell
Copy link
Member

I noticed we make use of coverallsapp/github-action@master near the bottom of in the Ci.yml and this results in a node 16 warning.

perhaps this could also be updated to version 2.2.3 or simply 2

https://github.com/coverallsapp/github-action

@MicahGale
Copy link
Contributor Author

So the issue here is that coveralls has a main and master branch, and only deploys to main. So I think using a specific version will be more consistent.

Copy link
Contributor

@paulromano paulromano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good, including that coveralls one going to v2. Thanks!

@paulromano paulromano merged commit 539f58d into openmc-dev:develop Mar 13, 2024
18 checks passed
@MicahGale MicahGale deleted the 2905-node-migration branch March 13, 2024 21:08
church89 pushed a commit to openmsr/openmc that referenced this pull request Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move CI to Node 20
3 participants