-
Notifications
You must be signed in to change notification settings - Fork 509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarifying documentation for Cones #2892
Clarifying documentation for Cones #2892
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this update @MicahGale! Minor changes suggested here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some class name corrections and a typo fix to tackle but then I think this looks good!
I came across this documentation:
I feel like "ambiguity" surface here is a bit counterintuitive. Would "disambiguation" surface be better? |
Based on the purpose described here, I would agree. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @MicahGale!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @MicahGale!
Description
This provides some clarification on how
Cone
surfaces are formed, to address some user confusion that occured.Fixes #2891.
Checklist
I have run clang-format (version 15) on any C++ source files (if applicable)I have added tests that prove my fix is effective or that my feature works (if applicable)