Added checks that tolerance value is between 0 and 1 #2884
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While using material.get_decay_photon_energy() I realised that you can set the clip_tolerance to greater than 1 and the simulation will run. However this value should be a fraction. I have added 2 checks to the clip method that ensure the value is between 0 and 1 to protect against misuse in future. I have also added to the tests to confirm that these checks work.
Checklist