Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix expansion filter merging #2882

Merged
merged 2 commits into from
Feb 29, 2024
Merged

Conversation

gridley
Copy link
Contributor

@gridley gridley commented Feb 25, 2024

Description

Lets expansion filters be merged by addressing the fact that they don't just take a list of bins as a constructor argument.

Fixes #2881

Checklist

  • I have performed a self-review of my own code
  • I have run clang-format (version 15) on any C++ source files (if applicable)
  • I have followed the style guidelines for Python source files (if applicable)
  • I have made corresponding changes to the documentation (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)

Copy link
Contributor

@paulromano paulromano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gridley!

@paulromano paulromano enabled auto-merge (squash) February 28, 2024 22:06
@paulromano paulromano merged commit 02c0a09 into openmc-dev:develop Feb 29, 2024
17 checks passed
@gridley gridley deleted the expansion_merging branch July 10, 2024 18:23
church89 pushed a commit to openmsr/openmc that referenced this pull request Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transport-corrected MGXS generation with merging broken
2 participants