Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use empty Result list get redistributed prev_results #2879

Closed
wants to merge 1 commit into from

Conversation

mjlong
Copy link

@mjlong mjlong commented Feb 18, 2024

Description

when distributing previous results for MPI, the empty results to load distributed previous results were constructed inappropriately.
Currently, the supposed to be empty results read results from "depletion_results.h5" in the current directory.
This leads to errors of file not found if previous results are not stored "depletion_results.h5" in the current directory.
It also makes the output "depletion_results.h5" mingled with results from "depletion_results.h5" in the current directory, instead of the previous results passed in constructing the transport operator.

Fixes #2878

Checklist

  • I have performed a self-review of my own code
  • I have run clang-format (version 15) on any C++ source files (if applicable)
  • I have followed the style guidelines for Python source files (if applicable)
  • I have made corresponding changes to the documentation (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)

@mjlong mjlong requested a review from drewejohnson as a code owner February 18, 2024 16:37
@church89
Copy link
Contributor

Hi @mjlong , I've already noticed the same thing and opened this PR a few weeks ago ;)

@paulromano
Copy link
Contributor

Closing as this is a duplicate of #2778

@paulromano paulromano closed this Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

failure and error when restart depletion with MPI on
3 participants