Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed unused step_index arg from restart #2867

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

shimwell
Copy link
Member

@shimwell shimwell commented Feb 9, 2024

While looking through the openmc.deplete.abc file I noticed _get_bos_data_from_restart takes an step_index argument that is not used in the method. Perhaps we can remove this argument. I grepped for use of this method and it was only used in a couple of places so I updated those to no longer pass in the argument.

Fixes # (issue)

Checklist

  • I have performed a self-review of my own code
  • I have followed the style guidelines for Python source files (if applicable)
  • I have made corresponding changes to the documentation (if applicable)

Copy link
Contributor

@paulromano paulromano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@paulromano paulromano merged commit a8f7a61 into openmc-dev:develop Feb 28, 2024
18 checks passed
church89 pushed a commit to openmsr/openmc that referenced this pull request Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants