Add bounding_box property to RectilinearMesh and UnstructuredMesh #2861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pshriwise
reviewed
Jan 30, 2024
openmc/mesh.py
Outdated
| Axis-aligned cartesian bounding box of cell defined by upper-right and lower- | ||
| left coordinates | ||
| bounding_box : openmc.BoundingBox | ||
| Axis-aligned bounding box of the cell defined by the upper-right and |
There was a problem hiding this comment.
Suggested change
| Axis-aligned bounding box of the cell defined by the upper-right and | |
| Axis-aligned bounding box of the mesh as defined by the upper-right and |
pshriwise
reviewed
Jan 30, 2024
openmc/mesh.py
Outdated
| @@ -1666,8 +1675,8 @@ class SphericalMesh(StructuredMesh): | |||
| The upper-right corner of the structured mesh. If only two coordinate | |||
| are given, it is assumed that the mesh is an x-y mesh. | |||
| bounding_box : openmc.BoundingBox | |||
| Axis-aligned bounding box of the cell defined by the upper-right and lower- | |||
| left coordinates | |||
| Axis-aligned bounding box of the cell defined by the upper-right and | |||
There was a problem hiding this comment.
Suggested change
| Axis-aligned bounding box of the cell defined by the upper-right and | |
| Axis-aligned bounding box of the mesh as defined by the upper-right and |
pshriwise
requested changes
Jan 30, 2024
There was a problem hiding this comment.
Thanks for completing these methods @paulromano! A couple of small nitpicks in the doc strings and we'll get this merged in asap.
pshriwise
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I noticed that
bounding_box,lower_left, andupper_rightproperties were missing on theRectilinearMeshandUnstructuredMeshclasses. This small PR adds them in. ForUnstructuredMesh, those properties only work when the mesh has been loaded from a statepoint (and vertex information is available).Checklist
I have run clang-format (version 15) on any C++ source files (if applicable)