-
Notifications
You must be signed in to change notification settings - Fork 509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changing y axis label for heating plots #2859
changing y axis label for heating plots #2859
Conversation
Hello Jon, Best, |
Just to mention if this PR is successful then I would be keen to follow up with a PR that fixes the axis label when MT 444 damage is plotted. I think the units for the 444 reaction units are |
Just wondering if anyone has had time to review this an if there are any changes needed. |
Thanks for the ping @shimwell. Will take a look soon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made a small fix to add the "damage-energy" score, which is also eV-barn. Good to go now; thanks!
Thanks for adding damage energy. That subset change is also better than the way I was doing it. Many thanks for the review. |
Co-authored-by: Paul Romano <[email protected]>
While plotting some heating cross sections we noticed that the units on the Y axis were in barns when perhaps they should be in eV/collision or something else.
This PR adds special handeling if the
heating
orheating-local
types are plotted.It also checks that the cross sections are not mixing heat with non heat cross sections as these can't share a Y axis units
I've added tests for the new use cases
Here is a before and after screen shot
sample code for these plots
tagging @rlbarker for your interest
Checklist