Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed error raising when calling warn #2853

Merged
merged 1 commit into from
Jan 20, 2024

Conversation

shimwell
Copy link
Member

I triggered this warn statement and noticed that the raise in front of the warn causes the program to terminate with and error stating one can only raise errors. I believe warn should not be raised like we have elsewhere in the code.

Fixes # (issue)
code having fatal error when it should just warn user

Checklist

  • I have performed a self-review of my own code
  • I have followed the style guidelines for Python source files (if applicable)

@paulromano paulromano merged commit b97149d into openmc-dev:develop Jan 20, 2024
18 checks passed
church89 pushed a commit to openmsr/openmc that referenced this pull request Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants