Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating file extension for Excel files when exporting MGXS data #2852

Merged
merged 2 commits into from
Jan 19, 2024

Conversation

pshriwise
Copy link
Contributor

@pshriwise pshriwise commented Jan 19, 2024

Description

As I was updating some of the notebook material to work with v0.14.0, I noticed that exporting MGXS/MDGXS data to an excel format with extension .xls no longer works b/c pandas deprecated support for that format sometime last year. Relevant pandas PR is here.

This simply updates the extension of excel files to .xlsx to comply with the change in pandas. I didn't add any tests here since the excel writing option is an optional dependency for pandas, but I'd be happy to do so if

Checklist

  • I have performed a self-review of my own code
  • I have run clang-format (version 15) on any C++ source files (if applicable)
  • I have followed the style guidelines for Python source files (if applicable)
  • I have made corresponding changes to the documentation (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)

Copy link
Contributor

@paulromano paulromano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@paulromano paulromano enabled auto-merge (squash) January 19, 2024 20:33
@paulromano paulromano merged commit 0785500 into openmc-dev:develop Jan 19, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants