Updating file extension for Excel files when exporting MGXS data #2852
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As I was updating some of the notebook material to work with v0.14.0, I noticed that exporting MGXS/MDGXS data to an excel format with extension
.xls
no longer works b/cpandas
deprecated support for that format sometime last year. Relevantpandas
PR is here.This simply updates the extension of excel files to
.xlsx
to comply with the change inpandas
. I didn't add any tests here since the excel writing option is an optional dependency forpandas
, but I'd be happy to do so ifChecklist