adding resulting nuclide to cross section plot legend #2851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Something isn't right there -
Ta181(n,a) can't go upto Re185, it should be Re177 right? when you loose an alpha you lose 4 nucleons
On Fri, 2024-01-19 at 08:59 -0800, Jonathan Shimwell wrote:
This PR attempts to add the resulting nuclide to the legend in the cross section plot.
On the left we have the resulting plot currently and on the right we have the plot after this PR
Screenshot.from.2024-01-19.16-51-39.png (view on web)
Checklist * I have performed a self-review of my own code
* I have followed the style guidelines for Python source files (if applicable)
You can view, comment on, or merge this pull request online at: #2851
Commit Summary * 6a21741 adding resulting nuclide to legend
* b3c07ac using existing import
File Changes (3 files)
* M openmc/data/data.py (87)
* M openmc/deplete/chain.py (169)
* M openmc/plotter.py (5)
Patch Links: * https://github.com/openmc-dev/openmc/pull/2851.patch
* https://github.com/openmc-dev/openmc/pull/2851.diff
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.******@***.***>>
|
|
Thanks @makeclean for spotting that I have updated the plot and code. |
paulromano
approved these changes
Feb 17, 2024
There was a problem hiding this comment.
Thanks @shimwell! FYI I made a change here removing the dadz from ReactionInfo rather than storing it redundantly. It was straightforward to just use the DADZ directly in the code below in chaing.py.
|
Many thanks Paul that is certainly more elegant |
church89
pushed a commit
to openmsr/openmc
that referenced
this pull request
Jul 18, 2024
Co-authored-by: Paul Romano <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to add the resulting nuclide to the legend in the cross section plot.
I have tried to make use of existing code by recycling the
dadzvalues originally from chain.py and placing them in data.py. I guess they might be useful elsewhere as wellOn the left we have the resulting plot currently and on the right we have the plot after this PR
*edited plot updated to fix bug spotted by @makeclean
Checklist