Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose Material::depletable in the CAPI #2843

Merged
merged 5 commits into from
Jan 17, 2024

Conversation

pshriwise
Copy link
Contributor

Description

Exposes the depletable attribute of materials in the CAPI and openmc.lib. Also makes an accessor for the attribute on the C++ class.

Along the way I noticed that the fissionable_ data member was public despite having an accessor so I moved it to the private section along with depletable_ and added a non-const accessor.

Fixes # (issue)

Checklist

  • I have performed a self-review of my own code
  • I have run clang-format (version 15) on any C++ source files (if applicable)
  • I have followed the style guidelines for Python source files (if applicable)
  • I have made corresponding changes to the documentation (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)

@shimwell
Copy link
Member

shimwell commented Jan 17, 2024

Hi @pshriwise I can't offer a full review here but did notice something that you might want to add.

The doc string for the Material class in openmc/lib/material.py might want to also include depletable so that it shows up in the read the docs.

I guess it could be added to this section
https://github.com/pshriwise/openmc/blob/58ee2f4bafbb3b1c994302ba873355ed3f623bfe/openmc/lib/material.py#L90-L104C1

@pshriwise
Copy link
Contributor Author

Hi @pshriwise I can't offer a full review here but did notice something that you might want to add.

The doc string for the Material class in openmc/lib/material.py might want to also include depletable so that it shows up in the read the docs.

I guess it could be added to this section https://github.com/pshriwise/openmc/blob/58ee2f4bafbb3b1c994302ba873355ed3f623bfe/openmc/lib/material.py#L90-L104C1

Thanks @shimwell! Can do 👍🏻

Copy link
Contributor

@paulromano paulromano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@paulromano paulromano enabled auto-merge (squash) January 17, 2024 18:44
@paulromano paulromano merged commit 057c33a into openmc-dev:develop Jan 17, 2024
17 checks passed
church89 pushed a commit to openmsr/openmc that referenced this pull request Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants