-
Notifications
You must be signed in to change notification settings - Fork 509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export model.tallies to XML in CoupledOperator #2840
Conversation
Since this is such a critical functionality, I've added a test to ensure we don't lose this again. |
Not my fault on the CI failure. Any suggestions on what to do about this?
|
Slightly related but do we have plans to move away from separate tallies.xml materials.xml etc and go for the model.xml for the CoupledOperator |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @gridley!
Description
The cause of the related issue was that the relatively new
Model
object's tallies variable was not being exported to XML. The olderCoupledOperator
code anticipated that users would have runtallies.export_to_xml()
, but that's not how we do stuff with theModel
class. Since the depletion interface now usesModel
, that's a confusing expectation! It's by far best to have theCoupledOperator
also export the tallies and plots file if they're present onModel
.Fixes #2839
Checklist