Fix config change not propagating through to decay energies #2825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changing the
openmc.configchain file was not propagating through to changing theDECAY_ENERGIESvariable, giving incorrect results if a user wished to compare decay heats between two chains.For example, I was trying to assess how much error the CASL decay chain introduced compared to the full ENDF chain. I was finding some strange results, with decay heat far below 7% for a PWR pin cell.
Fixes #2824
Also ran autopep8 on config.py.
Before this change (wrong)
After this change (right, expected 7% decay heat)