Reset timers at correct place in deplete #2821
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The particle/second and overall time reports in
openmc.deplete
are always wrong when using theCoupledOperator
. It turns out that we're only resetting the simulation timers when beginning-of-step material compositions are written, but this causes the run times to be summed as the simulation goes. We callopenmc.lib.reset()
after each transport solve, but don't reset the timers for some reason. As a result, you see a reported steadily decreasing particle tracking rate in each depletion step. For CECM with its two steps, it looks like:even though the tracking rate is not actually slowing down. This was quite confusing to me, as it seemed like we were somehow slowing down the simulation in the intermediate depletion steps!
After making the change here, the correct particle tracking rates are reported at each substep.