Fix distribcell labels for lattices used as fill in multiple cells #2813
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Partial fix for #2798. This fixes the creation of distribcell filter bin labels for the
tallies.out
file and theDistribcellFilter::get_all_bins
for models that fill more than one cell with the same lattice. Without this change, all tally cell instance results are attributed to the set of cell instances in the first use of the lattice. I've extended thetest_cell_instances.py
to ensure that the tallies.out file is written successfully and that tally results are present for all bins in the test problem to verify that this fix is correct.Note: This fix only applies to the
RectangularLattice
further corrections are needed forHexagonalLattice
's (see #2798) for more info.Checklist
I have followed the style guidelines for Python source files (if applicable)I have made corresponding changes to the documentation (if applicable)