Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide error message if a cell path can't be determined #2812

Merged
merged 2 commits into from
Dec 27, 2023

Conversation

pshriwise
Copy link
Contributor

@pshriwise pshriwise commented Dec 19, 2023

Description

@lewisgross1296 reported a segmentation fault when generatig text labels for a tally using a distribcell filter and hexagonal lattices (more info in #2798).

This small PR adds an error message in the case that we search all of the cells in a universe without finding an appropriate universe or lattice fill to continue the search.

Checklist

  • I have performed a self-review of my own code
  • I have run clang-format (version 15) on any C++ source files (if applicable)
  • I have followed the style guidelines for Python source files (if applicable)
  • I have made corresponding changes to the documentation (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)

Copy link
Contributor

@paulromano paulromano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pshriwise!

@paulromano paulromano merged commit 4116566 into openmc-dev:develop Dec 27, 2023
18 checks passed
church89 pushed a commit to openmsr/openmc that referenced this pull request Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants