adding get_all_nuclides method to geometry class #2796
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I've been using
openmc.deplete.get_microxs_and_flux(nuclides =...)
and wanting to pass in the nuclides present in the geometry. Having the proposed simpleget_all_nuclides
method on the geometry class would save me some user script inconvenience. Getting a mutable flat sequenceof all the nuclides without duplicates can certainly be done on the user script it is just a mild inconvenience.Fixes # (issue)
Checklist