Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding get_all_nuclides method to geometry class #2796

Merged
merged 2 commits into from
Dec 12, 2023

Conversation

shimwell
Copy link
Member

@shimwell shimwell commented Dec 2, 2023

Description

I've been using openmc.deplete.get_microxs_and_flux(nuclides =...) and wanting to pass in the nuclides present in the geometry. Having the proposed simple get_all_nuclides method on the geometry class would save me some user script inconvenience. Getting a mutable flat sequenceof all the nuclides without duplicates can certainly be done on the user script it is just a mild inconvenience.

Fixes # (issue)

Checklist

  • I have performed a self-review of my own code
  • I have followed the style guidelines for Python source files (if applicable)
  • I have made corresponding changes to the documentation (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)

Copy link
Contributor

@paulromano paulromano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shimwell Thanks for the PR here. I just updated it to improve the efficiency (using a set rather than a list while accumulating the nuclides).

@paulromano paulromano enabled auto-merge (squash) December 12, 2023 19:47
@paulromano paulromano merged commit 15a2199 into openmc-dev:develop Dec 12, 2023
17 checks passed
church89 pushed a commit to openmsr/openmc that referenced this pull request Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants