OpenMPMutex "Copying"

[jtramm]

Description

The original OpenMPMutex class definition deletes the copy operator and copy assignment operators. This was a reasonable strategy, as if we copy this object then only a shallow copy is performed (i.e., destroying the original object will uninitialize the omp_lock_t within the new copied object). While deletion of these operators works, it also precludes the class from being stored in various STL containers that might need to copy or move the objects (e.g., std::vector).

Given that omp_lock_t objects are inherently fungible, we can just define the copy operators with default construction. I.e., copying just creates a new object, it does not copy anything from the original object. This allows for usage of the object in STL containers like vectors.

For performance, we might also want to implement move operators, but I'm hesitant to introduce even more code that may not be used and likely isn't going to be covered by testing. Additionally, as movement of locks would only ever be done during program initialization, there is no tangible benefit to the move semantics, so probably not worth the extra code.

Checklist

• I have performed a self-review of my own code
• I have run clang-format (version 15) on any C++ source files (if applicable)

[pshriwise]

Thanks for this update @jtramm!