-
Notifications
You must be signed in to change notification settings - Fork 509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding get cylindrical mesh index at specified coordinates #2782
Merged
paulromano
merged 12 commits into
openmc-dev:develop
from
shimwell:adding_get_index_at_coords
Dec 12, 2023
Merged
Adding get cylindrical mesh index at specified coordinates #2782
paulromano
merged 12 commits into
openmc-dev:develop
from
shimwell:adding_get_index_at_coords
Dec 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulromano
requested changes
Nov 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a nice addition, thanks @shimwell! A few comments below:
Co-authored-by: Paul Romano <[email protected]>
Thanks for the review @paulromano I have gone through and I believe I've addressed all the review comments and adopted all suggestions. |
paulromano
approved these changes
Dec 12, 2023
church89
pushed a commit
to openmsr/openmc
that referenced
this pull request
Jul 18, 2024
…v#2782) Co-authored-by: Paul Romano <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR attempts to add the ability to get the cylindrical mesh index of a x,y,z coordinate. This is useful when users are trying to find the mesh value at a specific location.
usage is ...
Fixes # (issue)
Checklist