Fix lagrangian interpolation #2775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shimwell
approved these changes
Nov 14, 2023
|
This works nicely and I see it has passed all the tests. Tagging with the will merge in less than 24 hours, let me know if there are objections |
shimwell
added
the
Merging Soon
shimwell
approved these changes
Nov 15, 2023
church89
pushed a commit
to openmsr/openmc
that referenced
this pull request
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes the y value used in Lagrangian interpolation to use the values in the local interval rather than only the ones at the beginning of the array. Tests have been added for correctness for several orders of interpolation with spot checks over all the interpolation orders we use in the
EnergyFunctionFilter.Fixes #2765
Checklist
- [ ] I have followed the style guidelines for Python source files (if applicable)- [ ] I have made corresponding changes to the documentation (if applicable)