Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to batch checks for simulation restarts #2390

Merged
merged 12 commits into from
Feb 22, 2023
Merged

Updates to batch checks for simulation restarts #2390

merged 12 commits into from
Feb 22, 2023

Conversation

pshriwise
Copy link
Contributor

Resolves #2389

Additional changes:

  • change to allow openmc.Pathlike to be passed for the restart file in the Python API
  • "Pathlike" --> "PathLike" in docstrrings

@pshriwise
Copy link
Contributor Author

A couple more updates here:

  • Added a line that searches for the subelement <type> in <filter> nodes to support backward compatibility with older XML files (including those in our test suite)
  • Changed the comparison in load_state_point to use settings::n_max_batches to support continuation runs that use triggers

paulromano
paulromano requested changes Feb 21, 2023
View reviewed changes
openmc/executor.py Outdated Show resolved Hide resolved
src/state_point.cpp Outdated Show resolved Hide resolved
tests/regression_tests/statepoint_restart/test.py Outdated Show resolved Hide resolved
tests/regression_tests/statepoint_restart/test.py Outdated Show resolved Hide resolved
paulromano
paulromano requested changes Feb 21, 2023
View reviewed changes
Copy link
Contributor

@paulromano paulromano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more little pathlib trick for ya:

tests/regression_tests/statepoint_restart/test.py Outdated Show resolved Hide resolved
@paulromano paulromano merged commit 635e573 into openmc-dev:develop Feb 22, 2023
@pshriwise pshriwise mentioned this pull request Feb 29, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulromano paulromano paulromano approved these changes

@eepeterson eepeterson Awaiting requested review from eepeterson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Simulation restart isn't terminated correctly
2 participants
@pshriwise @paulromano