Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken dependency message_queue for moonlight-tv #7

Closed

Conversation

GuillaumeSmaha
Copy link
Contributor

I was able to find the code for the broken dependency on moonlight-tv: https://github.com/GuillaumeSmaha/message_queue (2 files)
I found a way to fix it by using git config --global: GuillaumeSmaha@66cbde3
I am not very happy with the solution because using --global is not the best.
I tried with these solution but it doesn't work

define MOONLIGHT_TV_PATCH_SUBMODULE
	mkdir -p $(MOONLIGHT_TV_DL_DIR)/git
	cd $(MOONLIGHT_TV_DL_DIR)/git ; git init ; git config url."https://github.com/GuillaumeSmaha/message_queue".insteadOf "https://github.com/LnxPrgr3/message_queue"
endef

It doesn't work because the next call to git init will erase the config.

MOONLIGHT_TV_GIT_SUBMODULES = NO
define MOONLIGHT_TV_PATCH_SUBMODULE
	cd $(MOONLIGHT_TV_DL_DIR)/git ; git config url."https://github.com/GuillaumeSmaha/message_queue".insteadOf "https://github.com/LnxPrgr3/message_queue" ; git submodule update --init
endef
MOONLIGHT_TV_POST_DOWNLOAD_HOOKS += MOONLIGHT_TV_PATCH_SUBMODULE

It doesn't work too because the tar file is already created and the call to git submodule update --init is useless

Another solution could be to duplicate moonlight-tv repositories and create new version 1.3.2 with a change to the submodule configuration.

Use "git config --global" to replace the broken dependency by a reupload
of the code.
@GuillaumeSmaha GuillaumeSmaha mentioned this pull request Sep 7, 2022
@smx-smx
Copy link
Member

smx-smx commented Sep 7, 2022

If updating moonlight-tv fixes the issue, let's do it. There's no specific reason for having v1.3.1 (it was the one available at the time)

@GuillaumeSmaha
Copy link
Contributor Author

I was hesitating to do that at first when I saw there is a dependency on npm.
I will try to upgrade it tomorrow :)

@GuillaumeSmaha GuillaumeSmaha deleted the fix_moonlight-tv branch September 7, 2022 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants