Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Datagram display improved; CDI max & min enforced #258

Merged
merged 4 commits into from
Apr 18, 2024
Merged

Datagram display improved; CDI max & min enforced #258

merged 4 commits into from
Apr 18, 2024

Conversation

bobjacobsen
Copy link
Contributor

  • improve how the payload of DatagramAcknowledged and DatagramRejected messages are handled and displayed
  • enforce the max and min elements when doing integer input via CDI
    • added max and min values to the tooltips
    • changed getMax and getMin methods to return a long to allow for unsigned 4-byte values
    • "Write" button disabled if input is out of range

@bobjacobsen bobjacobsen mentioned this pull request Apr 12, 2024
Merged
@dpharris dpharris merged commit b133728 into openlcb:master Apr 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bobjacobsen @dpharris