Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes the network tree navigable by keyboard #187

Merged
merged 2 commits into from
Apr 7, 2021

Conversation

balazsracz
Copy link
Collaborator

Listens to keyboard and mouse actions on the tree pane.
Triggers the client action on mouse click and on keyboard enter/space.

Removes triggering the client action upon selection changes. Removes
code that artificially cleared the selection upon any selection change.
This enables using the keyboard for navigating the tree without false triggers.
Up/down/left/right arrows now do as we expect them to do.

Making the keyboard navigation work on the JTree is important for accessibility.

Makes the subtree expansion work on a single click for enable easier use.

Triggers the client action on mouse click and on keyboard enter/space.

Removes triggering the client action upon selection changes. Removes
code that artificially cleared the selection upon any selection change.
This enables using the keyboard for navigating the tree. Up/down/left/right
arrows now do as we expect them to do.
@balazsracz balazsracz merged commit 84b3e01 into master Apr 7, 2021
@balazsracz balazsracz deleted the bracz-treepane-keyboard branch April 7, 2021 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant