Correct/improve dragbox docs #2204
Conversation
| * for zooming to a specific area of the map | ||
| * (see {@link ol.interaction.DragZoom} and | ||
| * {@link ol.interaction.DragRotateAndZoom}), or for selecting specific | ||
| * features. |
There was a problem hiding this comment.
Do we really use the dragboxinteraction to select specific features (yet)?
There was a problem hiding this comment.
maybe not, but I think the point is that dragbox can be used for things other than zooming. I can take out that comment if you like (and try and remember to put it back when the selection example is merged)
| * A conditional modifier (i.e. Shift key) that determines if the interaction is | ||
| * active or not, default is shify key. | ||
| * A conditional modifier (such as the Shift key) that determines if the | ||
| * interaction is active or not; default is shift key. |
There was a problem hiding this comment.
I think we should we be capitalizing Shift consistently.
|
I agree with #2204 (comment) that the current description for 'condition' needs changing. However, this is not specific to dragbox; all the condition options say the same thing. The same applies to the comments on consistent shift/Shift. I've removed changes to olx.js from this PR and will submit another PR to change all condition option descriptions. |
|
Makes sense. Thanks Peter. |
|
Agreed. This looks good to me. |
|
We can address consistency of |
|
right, overlooked that - thanks. |
docs only, no logic change.
Was going to include a reference to the box-selection example #1959, but that hasn't been merged yet :-)