Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept Promise as return type for transformRequest #1012

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

ahocevar
Copy link
Member

@ahocevar ahocevar commented Nov 2, 2023

This pull request enables transformRequest() to return a Promise resolving to a Request or url string, instead of just a Request or an url string. This allows users that need to add auth headers to obtain those headers asynchronously:

transformRequest: async (url, type) => {
  return new Request(
    url,
    {
      headers: await getAuthHeaders()
    }
  );
}

@ahocevar ahocevar merged commit f372302 into main Nov 2, 2023
1 check passed
@ahocevar ahocevar deleted the async-transformrequest branch November 2, 2023 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant