Add some externs #487
Merged
Add some externs #487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gberaudo
reviewed
Aug 30, 2017
| @@ -2763,6 +2768,11 @@ Cesium.CustomDataSource.prototype.entities; | |||
| */ | |||
| Cesium.EntityCollection = function() {} | |||
|
|
|||
| /** | |||
| * @param {string} id | |||
There was a problem hiding this comment.
According to Cesium code, it looks to me that it should be String|Number. I opened a tentative fix in Cesium, see CesiumGS/cesium#5791.
There was a problem hiding this comment.
It appears your previous attempt was the good one. Can you revert to it?
oterral
force-pushed
the
teo_add_externs
branch
from
dbfd9fd to
92befae
Compare
|
Let's see the outcome of the Cesium PR before merging. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.