Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PR template #54

Merged
merged 2 commits into from
Mar 21, 2019
Merged

Add PR template #54

merged 2 commits into from
Mar 21, 2019

Conversation

augb
Copy link
Contributor

@augb augb commented Mar 21, 2019

The idea is for contributors to fill-out the description and have the code review checklist as a guide in developing the PR.

The code reviewer is the one who will complete the code review checklist (checking all boxes) before approving.

@augb augb added the docs Documentation related label Mar 21, 2019
@augb augb self-assigned this Mar 21, 2019
@augb augb requested a review from danixeee March 21, 2019 14:59
Copy link
Contributor

@danixeee danixeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; merge when ready

@augb augb merged commit 70ab601 into master Mar 21, 2019
@augb augb deleted the augb/add-pr-template branch March 21, 2019 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants