Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid unwanted "null"s in server capabilities #166

Merged
merged 1 commit into from
Mar 30, 2021
Merged

Avoid unwanted "null"s in server capabilities #166

merged 1 commit into from
Mar 30, 2021

Conversation

dimbleby
Copy link
Contributor

Description (e.g. "Related to ...", etc.)

Avoid setting fields in server capabilities to None, because explicitly setting them causes pydantic to serialize them, which is not what is wanted.

See pappasam/jedi-language-server#108

Code review checklist (for code reviewer to complete)

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Commit messages are meaningful (see this for details)
  • Tests have been included and/or updated, as appropriate
  • Docstrings have been included and/or updated, as appropriate
  • Standalone docs have been updated accordingly
  • CONTRIBUTORS.md was updated, as appropriate
  • Changelog has been updated, as needed (see CHANGELOG.md)

Copy link
Contributor

@danixeee danixeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@danixeee danixeee merged commit 82a452f into openlawlibrary:master Mar 30, 2021
@dimbleby dimbleby deleted the null-capabilities branch March 30, 2021 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants