Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Periodically check client pid and exit server #149

Merged
merged 2 commits into from
Mar 16, 2021

Conversation

danixeee
Copy link
Contributor

@danixeee danixeee commented Mar 15, 2021

Description (e.g. "Related to ...", etc.)

Closes #118, #130.

Ensures that pygls process will terminate if the client process is not alive.

Code review checklist (for code reviewer to complete)

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Commit messages are meaningful (see this for details)
  • Tests have been included and/or updated, as appropriate
  • Docstrings have been included and/or updated, as appropriate
  • Standalone docs have been updated accordingly
  • CONTRIBUTORS.md was updated, as appropriate
  • Changelog has been updated, as needed (see CHANGELOG.md)

@danixeee danixeee added the bug Something isn't working label Mar 15, 2021
@danixeee danixeee requested a review from renatav March 15, 2021 23:48
@danixeee danixeee self-assigned this Mar 15, 2021
@danixeee danixeee force-pushed the danixeee/check-client-process branch from 3aab7aa to a4e4908 Compare March 15, 2021 23:51
@danixeee
Copy link
Contributor Author

@dimbleby This was a quick fix, I will release updates tomorrow. You can also check this PR if you wish.

Copy link
Contributor

@renatav renatav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one typo. Looks good to me

pygls/utils.py Outdated Show resolved Hide resolved
@danixeee danixeee force-pushed the danixeee/check-client-process branch from a4e4908 to 38dd100 Compare March 16, 2021 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stop once the exit notification is received
2 participants