-
-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run tests and linters on multiple python versions and on linux #100
Run tests and linters on multiple python versions and on linux #100
Conversation
6ae4169
to
e232b06
Compare
This is work in progress, this also contain the changes from #99 so that mypy test also pass. This has 8 jobs: 4 python versions * 2 OS versions, maybe we don't need so much and testing for example all python versions on windows and only python 3.8 on linux is enough. |
e232b06
to
adcc10d
Compare
This uses a trick from https://andrewlock.net/building-asp-net-core-apps-on-both-windows-and-linux-using-appveyor/#2-update-your-build-script-optional- to run windows only commands with There was some power shell steps to check the example extension, I have not adapted this for linux, this part is only tested on windows. |
9e7407d
to
2a58172
Compare
I'd highly recommend getting off appveyor in favor of azure pipelines (10 concurrent machines) or github actions (20 concurrent machines). |
8bab07f
to
76e0cc9
Compare
I have updated this, for now to include profiles to run tests on both appveyor and azure-pipelines, but the idea is that we should decide and keep only one. I have configured my fork of pygls to run on azure and on azure, it looks like this Total time on azure was 4m 12s. Total time on appveyor was 5m 49s ... which is strange because it's not the sum of all tests runs. This is the timing reported by both platforms. Test pass on all python versions for both platforms, but:
What are your thoughts ? |
I agree, we should keep only one. I prefer the one which is faster and have better open-source plan.
I think we could reuse some parts of code from here to build and upload vsix artifact, but that's not urgent since I am building it locally during reviews. |
@perrinjerome Sorry for the delay. We have created project in Azure devops, but I am not able to load yaml file from forked repository's branch. If everything is ready, please update your branch and create a PR. I will merge both azure and appveyor scripts to the master branch and make some changes after that. |
To run lint and tests on all supported python versions
This is required to make a source dist with python setup.py sdist on old python3.5. Tox includes such a step.
Some steps related to building the sample json extension are only on windows, because they are implemented in powershell.
This only runs tests and check extensions can be built. On appveyor there was steps to build/publish the sample json extension, this was not re-implemented here.
76e0cc9
to
e99ef92
Compare
@danixeee I updated this branch ( rebased on master ) and marked this PR "Ready for review". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
Description (e.g. "Related to ...", etc.)
Fixes #96
Code review checklist (for code reviewer to complete)