Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design updates #114

Closed
boonebgorges opened this issue Apr 19, 2018 · 6 comments
Closed

Design updates #114

boonebgorges opened this issue Apr 19, 2018 · 6 comments
Assignees
Milestone

Comments

@boonebgorges
Copy link
Collaborator

See https://www.dropbox.com/sh/ibelqxkpebe7xl1/AACVt7wutZE7O5f_yzPzlZkxa?dl=0

@boonebgorges boonebgorges self-assigned this Apr 19, 2018
@boonebgorges boonebgorges added this to the Fall 2018 milestone Apr 19, 2018
boonebgorges added a commit that referenced this issue Apr 19, 2018
boonebgorges added a commit to openlab-at-city-tech/openlab that referenced this issue Apr 19, 2018
@boonebgorges
Copy link
Collaborator Author

I've made these changes, but it might be best to hold off on testing them until after a review of #109.

@jennaspevack
Copy link
Collaborator

@boonebgorges, not sure if these css updates will address this, but it appears that the site logo on Production is cut off. And it also looks like there are some CSS conflicts (?) with the WP Navbar - ie: the spacing between menu items in the dropdowns are off.
https://www.dropbox.com/s/l6lz7q2y4nvu9wz/cssconflictswithWPnav.png?dl=0

@boonebgorges
Copy link
Collaborator Author

Yes, I'd noticed this, Jenna.

I did fix the header issue as part of the changes in this ticket. From what I can tell, it was due to an update in the Hemingway parent theme. I just put that small fix onto the production site so that you can see it in action.

The issues with the adminbar seem more complicated. I believe it's probably a more general problem than ol-webwork - it seems like the styling in themes is overriding the not-specific-enough network toolbar styling. I've opened a ticket on OpenLab for it. http://redmine.citytech.cuny.edu/issues/2302

@jennaspevack
Copy link
Collaborator

Okay, thanks!

@moui72
Copy link

moui72 commented May 27, 2018

as far as I can tell, the issues with design seem resolved -- is there any specific testing that needs to be done?

@boonebgorges
Copy link
Collaborator Author

As long Bree and Tyler are happy with things here, I think we can safely close. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants