Skip to content

Commit

Permalink
Improved labeling for subscription button.
Browse files Browse the repository at this point in the history
See #109.
  • Loading branch information
boonebgorges committed May 1, 2018
1 parent ebff122 commit 88cd43b
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 3 deletions.
6 changes: 5 additions & 1 deletion build/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -39408,7 +39408,11 @@ class SubscriptionDialog extends __WEBPACK_IMPORTED_MODULE_0_react__["Component"

return __WEBPACK_IMPORTED_MODULE_0_react___default.a.createElement(
'button',
{ className: iconClass, onClick: onClick },
{
'aria-label': screenReaderText,
className: iconClass,
onClick: onClick
},
__WEBPACK_IMPORTED_MODULE_0_react___default.a.createElement(
'span',
{ className: 'screen-reader-text' },
Expand Down
2 changes: 1 addition & 1 deletion build/index.js.map

Large diffs are not rendered by default.

6 changes: 5 additions & 1 deletion src/components/SubscriptionDialog.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,11 @@ export default class SubscriptionDialog extends Component {
}

return (
<button className={iconClass} onClick={onClick}>
<button
aria-label={screenReaderText}
className={iconClass}
onClick={onClick}
>
<span className="screen-reader-text">{ screenReaderText }</span>
<i className="fa"></i>
<div aria-hidden="true" className="hover-notice subscription-notice">
Expand Down

0 comments on commit 88cd43b

Please sign in to comment.