Rewrite workload control flow of BatchRelease controller #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #90 +/- ##
===========================================
+ Coverage 21.86% 32.93% +11.06%
===========================================
Files 38 38
Lines 4120 3486 -634
===========================================
+ Hits 901 1148 +247
+ Misses 3056 2133 -923
- Partials 163 205 +42
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
zmberg
reviewed
Oct 18, 2022
pkg/controller/batchrelease/batchrelease_special_cases_handler.go
Outdated
Show resolved
Hide resolved
| @@ -65,7 +66,7 @@ func (r *Executor) syncStatusBeforeExecuting(release *v1alpha1.BatchRelease, new | |||
| // handle the case that release plan is changed during progressing | |||
| reason = "PlanChanged" | |||
| message = "release plan is changed, then recalculate status" | |||
| signalRecalculate(release, newStatus) | |||
| utils.SignalRecalculate(release, newStatus) | |||
|
|
|||
| case isPlanUnhealthy(release): | |||
There was a problem hiding this comment.
What means is unhealthy? What scenarios can lead to unhealthy and how to get back to normal?
There was a problem hiding this comment.
What means is unhealthy?
- currentStepIndex > len(steps).
In this scene, we will try to restart from beginning.
| klog.InfoS("using statefulset-like batch release controller for this batch release", "workload name", targetKey.Name, "namespace", targetKey.Namespace) | ||
| return workloads.NewUnifiedWorkloadRolloutControlPlane(workloads.NewStatefulSetLikeController, r.client, r.recorder, release, newStatus, targetKey, gvk), nil | ||
| return batchstyle.NewControlPlane(statefulset.NewController, r.client, r.recorder, release, newStatus, targetKey, gvk), nil | ||
| } | ||
|
|
||
| func (r *Executor) moveToNextBatch(release *v1alpha1.BatchRelease, status *v1alpha1.BatchReleaseStatus) bool { |
There was a problem hiding this comment.
To simplify the logic, i think when batchPartition is nil, do not execute any batch.
| @@ -124,38 +123,38 @@ func (r *Executor) executeBatchReleasePlan(release *v1alpha1.BatchRelease, newSt | |||
| switch { | |||
There was a problem hiding this comment.
When progressDone is true, i think it do not come into Finalizing, but rather just to Completed. Finalizing State feel like it can be removed.
There was a problem hiding this comment.
Finalizing state cannot be skipped.
Finalizing state will delete some resources/annotations and restore some configuration for workloads.
furykerry
reviewed
Oct 24, 2022
pkg/controller/batchrelease/control/batchstyle/cloneset/control.go
Outdated
Show resolved
Hide resolved
pkg/controller/batchrelease/batchrelease_special_cases_handler.go
Outdated
Show resolved
Hide resolved
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
pkg/controller/batchrelease/control/partitionstyle/statefulset/control_test.go
Outdated
Show resolved
Hide resolved
pkg/controller/batchrelease/control/partitionstyle/statefulset/control_test.go
Outdated
Show resolved
Hide resolved
pkg/controller/batchrelease/control/partitionstyle/statefulset/control.go
Outdated
Show resolved
Hide resolved
pkg/controller/batchrelease/control/partitionstyle/cloneset/control.go
Outdated
Show resolved
Hide resolved
pkg/controller/batchrelease/control/partitionstyle/statefulset/control_test.go
Outdated
Show resolved
Hide resolved
pkg/controller/batchrelease/control/partitionstyle/statefulset/control_test.go
Outdated
Show resolved
Hide resolved
furykerry
reviewed
Nov 28, 2022
pkg/controller/batchrelease/control/partitionstyle/control_plane.go
Outdated
Show resolved
Hide resolved
pkg/controller/batchrelease/control/canarystyle/deployment/canary.go
Outdated
Show resolved
Hide resolved
pkg/controller/batchrelease/control/canarystyle/control_plane.go
Outdated
Show resolved
Hide resolved
furykerry
reviewed
Nov 28, 2022
veophi
force-pushed
the
rewrite-2
branch
2 times, most recently
from
20c7728 to
3411a4d
Compare
veophi
force-pushed
the
rewrite-2
branch
10 times, most recently
from
aec049b to
2dbe53d
Compare
zmberg
reviewed
Dec 1, 2022
api/v1alpha1/batchrelease_types.go
Outdated
| @@ -48,6 +48,7 @@ type BatchReleaseSpec struct { | |||
| // default is false | |||
| // +optional | |||
| Paused bool `json:"paused,omitempty"` | |||
| Cancel bool `json:"cancel,omitempty"` | |||
veophi
force-pushed
the
rewrite-2
branch
2 times, most recently
from
63ef2df to
b1be12f
Compare
furykerry
reviewed
Dec 1, 2022
Signed-off-by: mingzhou.swx <[email protected]>
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: furykerry The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: mingzhou.swx [email protected]
Ⅰ. Describe what this PR does
Rewrite workload control flow of BatchRelease controller
Improve unit test of BatchRelease controller