Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users define controller workers #67

Merged
merged 1 commit into from
Aug 23, 2022

Conversation

veophi
Copy link
Member

@veophi veophi commented Aug 23, 2022

Signed-off-by: mingzhou.swx [email protected]

Ⅰ. Describe what this PR does

Allow users define controller workers

@veophi veophi force-pushed the add-controller-workers branch from c8baf73 to f67d000 Compare August 23, 2022 06:00
@zmberg
Copy link
Member

zmberg commented Aug 23, 2022

/lgtm

@codecov-commenter
Copy link

Codecov Report

Merging #67 (f67d000) into master (65b75a6) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #67      +/-   ##
==========================================
+ Coverage   16.18%   16.20%   +0.02%     
==========================================
  Files          30       30              
  Lines        3460     3461       +1     
==========================================
+ Hits          560      561       +1     
  Misses       2800     2800              
  Partials      100      100              
Flag Coverage Δ
unittests 16.20% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...controller/batchrelease/batchrelease_controller.go 22.11% <100.00%> (ø)
pkg/controller/rollout/rollout_controller.go 12.50% <100.00%> (+1.59%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@furykerry
Copy link
Member

/approve

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: furykerry

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot kruise-bot merged commit 3d1df9c into openkruise:master Aug 23, 2022
yike21 pushed a commit to yike21/rollouts that referenced this pull request Aug 29, 2022
Signed-off-by: mingzhou.swx <[email protected]>

Signed-off-by: mingzhou.swx <[email protected]>
Co-authored-by: mingzhou.swx <[email protected]>
Signed-off-by: yike21 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants