-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve finalising logic for canary release #229
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #229 +/- ##
==========================================
+ Coverage 43.63% 44.76% +1.12%
==========================================
Files 52 55 +3
Lines 5681 6103 +422
==========================================
+ Hits 2479 2732 +253
- Misses 2778 2910 +132
- Partials 424 461 +37
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
c2ef833
to
733deb4
Compare
26e1aec
to
2695255
Compare
Signed-off-by: yunbo <[email protected]> improve finalising logic for canary release-2 Signed-off-by: yunbo <[email protected]>
/lgtm |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zmberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ⅰ. Describe what this PR does
rewrite the doCanaryFinalising function, mainly to modify the logic of rollback
before, this function executes the same steps for rollback and other scenarios (including success, pause, disabling):
however, in rollback scenario, running the first step (remove selector) will route some traffic unexpectedly to new version if user does A/B testing. Therefore, in rollback scenario, we instead route all traffic to stable service firstly, like:
note: i am not intended to modify the behaviours other than rollback (ie. success, pause, disabling), however, i find it is possible to simplify it, by combing the first step and the third step:
Ⅱ. Does this pull request fix one issue?
no
Ⅲ. Special notes for reviews