Inject requestHeaderModifier to LuaData #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
furykerry
reviewed
Jul 10, 2024
...ustomNetworkProvider/lua_configuration/networking.istio.io/VirtualService/trafficRouting.lua
Show resolved
Hide resolved
|
PTAL @furykerry |
|
@zmberg PTAL |
|
@lujiajing1126 please squash the commits into one |
* fix lua script and test case * use ptr instead of struct * add requestHeaderModifier to testcase debugging toolkit Signed-off-by: Megrez Lu <[email protected]>
lujiajing1126
force-pushed
the
inject-request-header-modifier
branch
from
008562a to
34a1848
Compare
Squashed. But I suppose maintainers can always merge and squash while merging the Pull Request on GitHub |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zmberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR does
In
TrafficRoutingStrategystruct,RequestHeaderModifieris allowed to be used for request header modification.But this field was not actually injected to the LuaData. Thus it cannot be used in the script.
Istio also supports HeaderOperations,
https://istio.io/latest/docs/reference/config/networking/virtual-service/#Headers-HeaderOperations
Ⅱ. Does this pull request fix one issue?
Ⅲ. Special notes for reviews