add 2 fields to status to support showing result of kubectl get #220
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR does
if we run
kubectl get rollout rollouts-demo
, we get result like this:the CANARY_STEP and CANARY_STATE are read from
rollout.status.CanaryStatus
, however, if we support blue-green, we cannot read the values from this path anymore, because the CanaryStatus will be nil. Therefore, i add copies of these two fields torollout.status
. They are only used to showing the brief result returned from kubectl get command.Ⅱ. Does this pull request fix one issue?
no
Ⅲ. Special notes for reviews