-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Path and QueryParams in http route matches #204
Support Path and QueryParams in http route matches #204
Conversation
Welcome @lujiajing1126! It looks like this is your first PR to openkruise/rollouts 🎉 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #204 +/- ##
==========================================
- Coverage 43.63% 43.45% -0.19%
==========================================
Files 52 52
Lines 5681 5682 +1
==========================================
- Hits 2479 2469 -10
- Misses 2778 2787 +9
- Partials 424 426 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Megrez Lu <[email protected]>
Signed-off-by: Megrez Lu <[email protected]>
Signed-off-by: Megrez Lu <[email protected]>
Signed-off-by: Megrez Lu <[email protected]>
Signed-off-by: Megrez Lu <[email protected]>
Signed-off-by: Megrez Lu <[email protected]>
Signed-off-by: Megrez Lu <[email protected]>
…idering case-insensitivity. (openkruise#200) * Fixed a bug caused by NOT considering case-insensitivity. Signed-off-by: yunbo <[email protected]> * add DisableGenerateCanaryService for CanaryStrategy amend1: update crd yaml amend2: add DisableGenerateCanaryService for v1alpha1 Signed-off-by: yunbo <[email protected]> --------- Signed-off-by: yunbo <[email protected]> Co-authored-by: yunbo <[email protected]> Signed-off-by: Megrez Lu <[email protected]>
Signed-off-by: Megrez Lu <[email protected]>
778ffc5
to
48bd9ea
Compare
I have some misunderstanding on the logical operator used for I will refactor the proposal and the implementation soon. |
Signed-off-by: Megrez Lu <[email protected]>
Signed-off-by: Megrez Lu <[email protected]>
Signed-off-by: Megrez Lu <[email protected]>
Signed-off-by: Megrez Lu <[email protected]>
Signed-off-by: Megrez Lu <[email protected]>
Signed-off-by: Megrez Lu <[email protected]>
Signed-off-by: Megrez Lu <[email protected]>
Signed-off-by: Megrez Lu <[email protected]>
Signed-off-by: Megrez Lu <[email protected]>
Signed-off-by: Megrez Lu <[email protected]>
Signed-off-by: Megrez Lu <[email protected]>
Signed-off-by: Megrez Lu <[email protected]>
Signed-off-by: Megrez Lu <[email protected]>
I've refactored semantics and implemented for MSE and istio scenarios. PTAL @zmberg Also the proposal has been updated. E2E tests are added as requested. |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zmberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ⅰ. Describe what this PR does
Add support for Path and QueryParams
Ⅱ. Does this pull request fix one issue?
Fixes #205
Ⅲ. Special notes for reviews
Supported list for
Path
:Istio
Supported list for
QueryParams
:Gateway API
Istio
MSE Ingress