Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support rolling publishing in AI scenarios #194

Closed
wants to merge 2 commits into from

Conversation

crain-cn
Copy link

@crain-cn crain-cn commented Jan 3, 2024

Ⅰ. Describe what this PR does

  1. Support Istio getaway to filter VirtualService retries fields
  2. Delete match with traffic judgment.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Special notes for reviews

@kruise-bot kruise-bot requested review from FillZpp and veophi January 3, 2024 09:34
@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign fillzpp for approval by writing /assign @fillzpp in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@crain-cn crain-cn force-pushed the feature/knative-rollout branch from f8ccef6 to 30dbda7 Compare January 3, 2024 09:34
Copy link

codecov bot commented Jan 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (678d4d2) 43.41% compared to head (e5efd3c) 43.41%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #194   +/-   ##
=======================================
  Coverage   43.41%   43.41%           
=======================================
  Files          52       52           
  Lines        5675     5675           
=======================================
  Hits         2464     2464           
  Misses       2786     2786           
  Partials      425      425           
Flag Coverage Δ
unittests 43.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@crain-cn crain-cn closed this Jan 3, 2024
@crain-cn crain-cn deleted the feature/knative-rollout branch January 3, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants