-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rollout v0.5.0 changelog #190
Conversation
Signed-off-by: liheng.zms <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #190 +/- ##
=======================================
Coverage 43.39% 43.39%
=======================================
Files 52 52
Lines 5666 5666
=======================================
Hits 2459 2459
Misses 2784 2784
Partials 423 423
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: liheng.zms <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Signed-off-by: liheng.zms <[email protected]>
CHANGELOG.md
Outdated
But we still recommend that you migrate to v1beta1 gradually, as some of the new features will only be available in v1beta1, | ||
e.g., [Extensible Traffic Routing Based on Lua Script](https://openkruise.io/rollouts/developer-manuals/custom-network-provider/). | ||
|
||
### Dump To V1beta1 Gateway API |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
replace dump with bump
CHANGELOG.md
Outdated
- Utilize a common Rollout configuration template to configure different resources, reducing configuration complexity and facilitating user configuration. | ||
|
||
### Traffic Routing with Istio | ||
Based on the lua script approach, we have built-in support for Istio resources VirtualService, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we have built-in support for Istio resources VirtualService
now we add built-in support for Istio resources VirtualService
CHANGELOG.md
Outdated
|
||
### Extensible Traffic Routing Based on Lua Script | ||
|
||
Kruise Rollout utilizes a Lua-script-based customization approach for API Gateway resources (Istio VirtualService, Apisix ApisixRoute, Kuma TrafficRoute and etc.). Kruise Rollout involves invoking Lua scripts to retrieve and update the desired configurations of resources based on release strategies and the original configurations of API Gateway resources (including spec, labels, and annotations). It enables users to easily adapt and integrate various types of API Gateway resources without modifying existing code and configurations. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
consider describe why we add lua support even we have gateway api support
|
||
WORKDIR / | ||
COPY --from=builder /workspace/manager . | ||
COPY lua_configuration /lua_configuration | ||
USER 1000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not use non-root user here ?
6a81e16
to
639544b
Compare
/lgtm |
Signed-off-by: liheng.zms <[email protected]>
639544b
to
04d314e
Compare
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zmberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ⅰ. Describe what this PR does
Ⅱ. Does this pull request fix one issue?
Ⅲ. Special notes for reviews