-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v1beta1 apis proposals #184
Conversation
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #184 +/- ##
==========================================
- Coverage 43.56% 43.40% -0.16%
==========================================
Files 52 52
Lines 5672 5667 -5
==========================================
- Hits 2471 2460 -11
- Misses 2778 2783 +5
- Partials 423 424 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
332d350
to
5389b51
Compare
api/v1beta1/rollout_types.go
Outdated
// Replicas is the number of expected canary pods in this batch | ||
// it can be an absolute number (ex: 5) or a percentage of total pods. | ||
Replicas *intstr.IntOrString `json:"replicas,omitempty"` | ||
DesiredReplicas *intstr.IntOrString `json:"desiredReplicas,omitempty"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
replicas already sounds concise and meaningful enough
// TrafficWeight indicate how many percentage of traffic the canary pods should receive | ||
// +optional | ||
TrafficWeight *int32 `json:"trafficWeight,omitempty"` | ||
// Set overwrites the request with the given header (name, value) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TrafficPercent, or just traffic? we can change the type to string so that users can known that it is a percent
5389b51
to
7a0a44d
Compare
0461f15
to
8f890b2
Compare
8f890b2
to
13397c8
Compare
Signed-off-by: liheng.zms <[email protected]>
13397c8
to
392268b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zmberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ⅰ. Describe what this PR does
Ⅱ. Does this pull request fix one issue?
Ⅲ. Special notes for reviews