Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1beta1 apis proposals #184

Merged
merged 1 commit into from
Dec 4, 2023
Merged

Conversation

zmberg
Copy link
Member

@zmberg zmberg commented Nov 7, 2023

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented Nov 7, 2023

Codecov Report

Attention: 47 lines in your changes are missing coverage. Please review.

Comparison is base (07b7f20) 43.56% compared to head (392268b) 43.40%.

Files Patch % Lines
...ok/rollout/validating/validate_v1alphal_rollout.go 0.00% 13 Missing ⚠️
...ollout/validating/rollout_create_update_handler.go 66.66% 5 Missing and 5 partials ⚠️
pkg/trafficrouting/network/gateway/gateway.go 0.00% 5 Missing ⚠️
pkg/util/controller_finder.go 0.00% 5 Missing ⚠️
pkg/controller/rollout/rollout_canary.go 78.57% 2 Missing and 1 partial ⚠️
pkg/controller/rollout/rollout_controller.go 0.00% 3 Missing ⚠️
...controller/batchrelease/batchrelease_controller.go 66.66% 0 Missing and 1 partial ⚠️
...troller/batchrelease/batchrelease_event_handler.go 75.00% 1 Missing ⚠️
...g/controller/batchrelease/batchrelease_executor.go 50.00% 0 Missing and 1 partial ⚠️
pkg/controller/deployment/util/deployment_util.go 80.00% 1 Missing ⚠️
... and 4 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #184      +/-   ##
==========================================
- Coverage   43.56%   43.40%   -0.16%     
==========================================
  Files          52       52              
  Lines        5672     5667       -5     
==========================================
- Hits         2471     2460      -11     
- Misses       2778     2783       +5     
- Partials      423      424       +1     
Flag Coverage Δ
unittests 43.40% <56.88%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zmberg zmberg force-pushed the v1beta1-apis-proposal branch 4 times, most recently from 332d350 to 5389b51 Compare November 10, 2023 11:28
// Replicas is the number of expected canary pods in this batch
// it can be an absolute number (ex: 5) or a percentage of total pods.
Replicas *intstr.IntOrString `json:"replicas,omitempty"`
DesiredReplicas *intstr.IntOrString `json:"desiredReplicas,omitempty"`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

replicas already sounds concise and meaningful enough

// TrafficWeight indicate how many percentage of traffic the canary pods should receive
// +optional
TrafficWeight *int32 `json:"trafficWeight,omitempty"`
// Set overwrites the request with the given header (name, value)
Copy link
Member

@furykerry furykerry Nov 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TrafficPercent, or just traffic? we can change the type to string so that users can known that it is a percent

@zmberg zmberg force-pushed the v1beta1-apis-proposal branch from 5389b51 to 7a0a44d Compare November 17, 2023 03:46
@zmberg zmberg force-pushed the v1beta1-apis-proposal branch 3 times, most recently from 0461f15 to 8f890b2 Compare November 17, 2023 09:32
@zmberg zmberg force-pushed the v1beta1-apis-proposal branch from 8f890b2 to 13397c8 Compare December 1, 2023 05:40
Signed-off-by: liheng.zms <[email protected]>
@zmberg zmberg force-pushed the v1beta1-apis-proposal branch from 13397c8 to 392268b Compare December 1, 2023 09:33
Copy link
Member

@furykerry furykerry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@zmberg
Copy link
Member Author

zmberg commented Dec 4, 2023

/approve

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zmberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot kruise-bot merged commit 9dcf365 into openkruise:master Dec 4, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants