Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rollout v1beta1 apis #182

Merged
merged 1 commit into from
Nov 3, 2023
Merged

rollout v1beta1 apis #182

merged 1 commit into from
Nov 3, 2023

Conversation

zmberg
Copy link
Member

@zmberg zmberg commented Nov 2, 2023

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented Nov 2, 2023

Codecov Report

Merging #182 (b476ff5) into master (a9a9430) will decrease coverage by 0.88%.
The diff coverage is 28.47%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##           master     #182      +/-   ##
==========================================
- Coverage   44.44%   43.56%   -0.88%     
==========================================
  Files          51       52       +1     
  Lines        5560     5672     +112     
==========================================
  Hits         2471     2471              
- Misses       2666     2778     +112     
  Partials      423      423              
Flag Coverage Δ
unittests 43.56% <28.47%> (-0.88%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...troller/batchrelease/batchrelease_event_handler.go 60.74% <100.00%> (ø)
pkg/controller/batchrelease/context/context.go 82.60% <100.00%> (ø)
...chrelease/control/canarystyle/deployment/canary.go 54.65% <ø> (ø)
...hrelease/control/canarystyle/deployment/control.go 74.35% <ø> (ø)
...chrelease/control/canarystyle/deployment/stable.go 56.66% <ø> (ø)
...release/control/partitionstyle/cloneset/control.go 74.69% <ø> (ø)
...elease/control/partitionstyle/daemonset/control.go 75.86% <ø> (ø)
...lease/control/partitionstyle/deployment/control.go 75.00% <ø> (ø)
...ease/control/partitionstyle/statefulset/control.go 81.81% <ø> (ø)
pkg/controller/batchrelease/labelpatch/filter.go 73.07% <100.00%> (ø)
... and 16 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: liheng.zms <[email protected]>
@veophi
Copy link
Member

veophi commented Nov 3, 2023

/LGTM

Copy link
Member

@furykerry furykerry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@furykerry
Copy link
Member

/approve

@kruise-bot kruise-bot merged commit d41b1fa into openkruise:master Nov 3, 2023
18 checks passed
@zmberg zmberg deleted the v1beta1-apis branch November 3, 2023 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants