Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for NodePort-type service #170

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

Kuromesi
Copy link
Contributor

Ⅰ. Describe what this PR does

Set the nodePort of the canary service to 0 in order to support a NodePort-type service. This will result in a random nodePort being allocated to the canary service, thereby avoiding any port conflicts.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Special notes for reviews

@codecov-commenter
Copy link

Codecov Report

Merging #170 (116337e) into master (72e1c0b) will increase coverage by 0.43%.
Report is 2 commits behind head on master.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master     #170      +/-   ##
==========================================
+ Coverage   43.44%   43.87%   +0.43%     
==========================================
  Files          50       50              
  Lines        5361     5374      +13     
==========================================
+ Hits         2329     2358      +29     
+ Misses       2635     2618      -17     
- Partials      397      398       +1     
Flag Coverage Δ
unittests 43.87% <100.00%> (+0.43%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pkg/trafficrouting/manager.go 52.40% <100.00%> (+15.30%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@zmberg
Copy link
Member

zmberg commented Aug 29, 2023

/lgtm

@zmberg
Copy link
Member

zmberg commented Aug 29, 2023

/approve

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zmberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot kruise-bot merged commit 76d33b8 into openkruise:master Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants